netdev - Re: [PATCH 1/1] net: fec: fix oops after transmit queue timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 14:12:42 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	George Joseph <george.joseph@...rview5.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Nimrod Andy <B38611@...escale.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Frank Li <Frank.Li@...escale.com>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH 1/1] net: fec: fix oops after transmit queue timeout

On Wed, Mar 11, 2015 at 2:00 PM, George Joseph
<george.joseph@...rview5.com> wrote:
> When a transmit queue timeout happens, dev_watchdog calls fec_timeout
> which in turns schedules fec_enet_timeout_work.  fec_enet_timeout_work
> uses container_of to get the private data structure (fep) then tries to
> use fep->netdev.  Unfortunately, nobody ever set fep->netdev so the result
> is a NULL pointer oops.
>
> With fep->netdev set right after fep is allocated in fep_probe, the
> drivers recovers nicely after the tx queue timeout.
>
> Signed-off-by: George Joseph <george.joseph@...rview5.com>
> Tested-by: George Joseph <george.joseph@...rview5.com>

Thanks for the patch, but this has already been fixed by:

commit 0c8185944a125621a1766615585238a3563ccac3
Author: Hubert Feurstein <h.feurstein@...il.com>
Date:   Wed Jan 7 14:48:17 2015 +0100

    net: fec: fix NULL pointer dereference in fec_enet_timeout_work

    This patch initialises the fep->netdev pointer. This pointer was not
    initialised at all, but is used in fec_enet_timeout_work and in some
    error paths.

    Signed-off-by: Hubert Feurstein <h.feurstein@...il.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html