netdev - Re: [PATCH net-next 1/8] net: Kill hold_net release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877funa15b.fsf@x220.int.ebiederm.org>
Date:	Wed, 11 Mar 2015 12:34:40 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	netdev@...r.kernel.org, stephen@...workplumber.org,
	nicolas.dichtel@...nd.com, roopa@...ulusnetworks.com,
	hannes@...essinduktion.org, ddutt@...ulusnetworks.com,
	vipin@...ulusnetworks.com, shmulik.ladkani@...il.com,
	dsahern@...il.com, Julian Anastasov <ja@....bg>
Subject: Re: [PATCH net-next 1/8] net: Kill hold_net release_net

Eric Dumazet <eric.dumazet@...il.com> writes:

> On Wed, 2015-03-11 at 11:35 -0500, Eric W. Biederman wrote:
>> hold_net and release_net were an idea that didn't work.  Kill them
>> it is long past due.
>
> Care to describe a bit more what is not working ?

Long ago and far away when I was first starting the network namespace
implementation hold_net and release_net were based on a misunderstanding
of what dev_hold and dev_release do.  I thought they were just for
debugging.  I cloned the concept and then later realized it added no
benefit to network namespaces.  The code has been disabled for more years
than I care to remember, and it is just dead weight now.

So it makes sense to remove the definitions now.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html