netdev - Re: [patch net-next] switchdev: select INET in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150311.141418.155308296302669143.davem@davemloft.net>
Date:	Wed, 11 Mar 2015 14:14:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexei.starovoitov@...il.com
Cc:	jiri@...nulli.us, netdev@...r.kernel.org, f.fainelli@...il.com,
	sfeldma@...il.com, rdunlap@...radead.org
Subject: Re: [patch net-next] switchdev: select INET in Kconfig

From: Alexei Starovoitov <alexei.starovoitov@...il.com>
Date: Wed, 11 Mar 2015 08:36:16 -0700

> On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>> This would fix randconfig compile error:
>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>
>> Also it fixes following warning:
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>
>> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>> ---
>>  net/switchdev/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>> index 86a47e1..3487940 100644
>> --- a/net/switchdev/Kconfig
>> +++ b/net/switchdev/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>  config NET_SWITCHDEV
>>         bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>> -       depends on INET
>> +       select INET
> 
> I believe Dave mentioned few times that 'select' is highly
> discouraged, since it doesn't work recursively.

Yes, the problem is that INET is not a leaf node.  It selects
CRYPTO stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html