netdev - Re: [PATCH] netfilter: ipset: make ip_set_get_ip*_port to use skb_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1503112009530.12147@blackhole.kfki.hu>
Date:	Wed, 11 Mar 2015 20:10:12 +0100 (CET)
From:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To:	Alexander Drozdov <al.drozdov@...il.com>
cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: ipset: make ip_set_get_ip*_port to use
 skb_network_offset

On Fri, 6 Mar 2015, Alexander Drozdov wrote:

> All the ipset functions respect skb->network_header value,
> except for ip_set_get_ip4_port() & ip_set_get_ip6_port(). The
> functions should use skb_network_offset() to get the transport
> header offset.
> 
> Signed-off-by: Alexander Drozdov <al.drozdov@...il.com>

Patch is applied, thanks.

Best regards,
Jozsef

> ---
>  net/netfilter/ipset/ip_set_getport.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/netfilter/ipset/ip_set_getport.c b/net/netfilter/ipset/ip_set_getport.c
> index 29fb01d..1981f02 100644
> --- a/net/netfilter/ipset/ip_set_getport.c
> +++ b/net/netfilter/ipset/ip_set_getport.c
> @@ -98,7 +98,7 @@ ip_set_get_ip4_port(const struct sk_buff *skb, bool src,
>  		    __be16 *port, u8 *proto)
>  {
>  	const struct iphdr *iph = ip_hdr(skb);
> -	unsigned int protooff = ip_hdrlen(skb);
> +	unsigned int protooff = skb_network_offset(skb) + ip_hdrlen(skb);
>  	int protocol = iph->protocol;
>  
>  	/* See comments at tcp_match in ip_tables.c */
> @@ -135,7 +135,9 @@ ip_set_get_ip6_port(const struct sk_buff *skb, bool src,
>  	__be16 frag_off = 0;
>  
>  	nexthdr = ipv6_hdr(skb)->nexthdr;
> -	protoff = ipv6_skip_exthdr(skb, sizeof(struct ipv6hdr), &nexthdr,
> +	protoff = ipv6_skip_exthdr(skb,
> +				   skb_network_offset(skb) +
> +					sizeof(struct ipv6hdr), &nexthdr,
>  				   &frag_off);
>  	if (protoff < 0 || (frag_off & htons(~0x7)) != 0)
>  		return false;
> -- 
> 1.9.1
> 

-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html