netdev - RE: [linuxppc-release] [PATCH] net/fsl: remove dependency FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 02:39:39 +0000
From:	Shaohui Xie <Shaohui.Xie@...escale.com>
To:	Emilian Medve <Emilian.Medve@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	Scott Wood <scottwood@...escale.com>
Subject: RE: [linuxppc-release] [PATCH] net/fsl: remove dependency FSL_SOC
 from MDIO

Hello Emil,

> On 03/10/2015 05:31 AM, shh.xie@...il.com wrote:
> > From: Shaohui Xie <Shaohui.Xie@...escale.com>
> >
> > FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> > can build on non-PPC platforms.
> 
> FSL_SOC is already defined for some ARM-based SoC? Why don't you use/fix
> that.
[S.H] I grep on top of the net-next tree, only found the FSL_SOC defined in arch/powerpc/Kconfig.

 We have plenty of devices integrated on both SoC families...
> 
> Or are you targeting other non-PPC/ARM SoC(s)?
[S.H] the point is to remove the unnecessary dependency to make the driver can build ARCH independently, no matter what the SoC is.

Thanks!
Shaohui

> 
> 
> Cheers,
> 
> 
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com>
> > ---
> >  drivers/net/ethernet/freescale/Kconfig | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/Kconfig
> > b/drivers/net/ethernet/freescale/Kconfig
> > index ba84c4a..25e3425 100644
> > --- a/drivers/net/ethernet/freescale/Kconfig
> > +++ b/drivers/net/ethernet/freescale/Kconfig
> > @@ -58,14 +58,12 @@ source
> "drivers/net/ethernet/freescale/fs_enet/Kconfig"
> >
> >  config FSL_PQ_MDIO
> >  	tristate "Freescale PQ MDIO"
> > -	depends on FSL_SOC
> >  	select PHYLIB
> >  	---help---
> >  	  This driver supports the MDIO bus used by the gianfar and UCC
> drivers.
> >
> >  config FSL_XGMAC_MDIO
> >  	tristate "Freescale XGMAC MDIO"
> > -	depends on FSL_SOC
> >  	select PHYLIB
> >  	select OF_MDIO
> >  	---help---
> >

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html