netdev - Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FFDFB0.6090004@windriver.com>
Date:	Wed, 11 Mar 2015 14:24:48 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<willemb@...gle.com>, <jon.maloy@...csson.com>,
	<Paul.Gortmaker@...driver.com>, <erik.hugne@...csson.com>,
	<fengguang.wu@...el.com>, <netdev@...r.kernel.org>,
	<tipc-discussion@...ts.sourceforge.net>, <kbuild-all@...org>
Subject: Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile
 error

On 03/11/2015 12:05 PM, David Miller wrote:
> From: Ying Xue <ying.xue@...driver.com>
> Date: Wed, 11 Mar 2015 11:11:37 +0800
> 
>> On 03/11/2015 12:47 AM, David Miller wrote:
>>> From: Willem de Bruijn <willemb@...gle.com>
>>> Date: Tue, 10 Mar 2015 11:41:03 -0400
>>>
>>>> On Tue, Mar 10, 2015 at 4:41 AM, Ying Xue <ying.xue@...driver.com> wrote:
>>>>> @@ -5,6 +5,7 @@
>>>>>  menuconfig TIPC
>>>>>         tristate "The TIPC Protocol"
>>>>>         depends on INET
>>>>> +       depends on (IPV6 || IPV6=n)
>>>>
>>>> Should this be limited to TIPC_MEDIA_UDP?
>>>
>>> I think it should.
>>>
>>>
>>
>> My first thought is also same as you. But when the dependency like (IPV6 ||
>> IPV6=n) is enforced to TIPC_MEDIA_UDP, it doesn't work in the below case:
>>
>> IPV6=m and TIPC=Y.
>>
>> In above condition, TIPC_MEDIA_UDP is still set to "Y".
> 
> It's because TIPC_MEDIA_UDP is bool, it needs to be a tristate.
> 

Yes, you are right. But as we don't implement UDP bearer as a module, I guess we
have to set TIPC_MEDIA_UDP as boolean type.

Regards,
Ying

> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html