netdev - Re: [PATCH net-next] net: add real socket cookies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150311.215424.1161505891201473105.davem@davemloft.net>
Date:	Wed, 11 Mar 2015 21:54:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, salo@...gle.com
Subject: Re: [PATCH net-next] net: add real socket cookies

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 11 Mar 2015 18:31:42 -0700

> Yes, but remember we use RCU with SLAB_DESTROY_BY_RCU thing,
> and inet_diag_dump_one_icsk() uses RCU as well.
> 
> I wanted to be extra careful here. Note that with v2, this
> atomic_cmpxchg() wont happen unless one dump operation previously
> revealed the SYN_RECV to the world.
> 
> I have no strong opinion and definitely it is currently safe to use
> atomic64_set() here.

Ok, it's just that we've worked so hard to minimize atomics in these
paths.

I'm ok with v2 of your patch and have applied it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html