netdev - Re: [PATCH] rtlwifi: get buffer_desc before trying to alloc new skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5501CCFB.3040203@lwfinger.net>
Date:	Thu, 12 Mar 2015 12:29:31 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Yang Bai <hamo.by@...il.com>, kvalo@...eaurora.org
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: get buffer_desc before trying to alloc new skb

On 03/12/2015 06:33 AM, Yang Bai wrote:
> if rtlpriv->use_new_trx_flow == true and we run out of memory
> to alloc a new skb, we will directly jump to no_new tag with
> buffer_desc == NULL. Then we will dereference this NULL pointer
> in function _rtl_pci_init_one_rxdesc.
>
> Signed-off-by: Yang Bai <hamo.by@...il.com>

Is the attached patch OK? I have tested it, but it is unlikely that I have hit 
any memory failures, thus that part needs to be checked by eye.

Larry



View attachment "0001-rtlwifi-get-buffer_desc-before-trying-to-alloc-new-s.patch" of type "text/x-patch" (1926 bytes)