netdev - Re: [PATCH net-next] team: Notify state change on ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150312.152907.1881565281406694368.davem@redhat.com>
Date:	Thu, 12 Mar 2015 15:29:07 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	jonasj76@...il.com
Cc:	jiri@...nulli.us, netdev@...r.kernel.org, ogerlitz@...lanox.com,
	monis@...lanox.com, jonas.johansson@...termo.se
Subject: Re: [PATCH net-next] team: Notify state change on ports

From: Jonas Johansson <jonasj76@...il.com>
Date: Thu, 12 Mar 2015 17:03:56 +0100

> +static void team_notify_port_work(struct work_struct *work)
> +{
> +	struct team *team;
> +	struct team_port_notify *notify;
> +
> +	team = container_of(work, struct team, notify_ports.dw.work);
> +
> +	if (!rtnl_trylock()) {
> +		schedule_delayed_work(&team->notify_ports.dw, 0);
> +		return;
> +	}
> +	rcu_read_lock();

This endless retry logic has the same problems as the issue being
worked on right now in the bonding notifiers.

We need something more sane, therefore I suggest we wait for the
bonding case to be worked out and then we can apply that solution
here as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html