netdev - Re: [PATCH net-next 2/7] inet: add ireq_state field to inet_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150312.184104.1561012099436884851.davem@davemloft.net>
Date:	Thu, 12 Mar 2015 18:41:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	edumazet@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/7] inet: add ireq_state field to
 inet_request_sock

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 12 Mar 2015 14:50:11 -0700

> diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c
> index 6bcaa33cd804..8febaeb12f6d 100644
> --- a/net/dccp/ipv6.c
> +++ b/net/dccp/ipv6.c
> @@ -403,6 +403,9 @@ static int dccp_v6_conn_request(struct sock *sk, struct sk_buff *skb)
>  	ireq = inet_rsk(req);
>  	ireq->ir_v6_rmt_addr = ipv6_hdr(skb)->saddr;
>  	ireq->ir_v6_loc_addr = ipv6_hdr(skb)->daddr;
> +	write_pnet(&ireq->ireq_net, sock_net(sk));
> +	ireq->ireq_state = TCP_NEW_SYN_RECV;
> +	atomic64_set(&ireq->ir_cookie, 0);
>  
>  	if (ipv6_opt_accepted(sk, skb, IP6CB(skb)) ||
>  	    np->rxopt.bits.rxinfo || np->rxopt.bits.rxoinfo ||
 ...
> diff --git a/net/ipv6/syncookies.c b/net/ipv6/syncookies.c
> index 7337fc7947e2..d8b4fed2a9b6 100644
> --- a/net/ipv6/syncookies.c
> +++ b/net/ipv6/syncookies.c
> @@ -196,6 +196,8 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb)
>  	ireq = inet_rsk(req);
>  	treq = tcp_rsk(req);
>  	treq->listener = NULL;
> +	write_pnet(&ireq->ireq_net, sock_net(sk));
> +	ireq->ireq_state = TCP_NEW_SYN_RECV;
>  
>  	if (security_inet_conn_request(sk, skb, req))
>  		goto out_free;

The write_pnet() and atomic64_set() calls in these hunks seem
completely unrelated to this change, and are in fact bug fixes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html