netdev - Re: [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55010968.5090606@windriver.com>
Date:	Thu, 12 Mar 2015 11:35:04 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<jon.maloy@...csson.com>, <Paul.Gortmaker@...driver.com>,
	<erik.hugne@...csson.com>, <fengguang.wu@...el.com>,
	<netdev@...r.kernel.org>, <willemb@...gle.com>,
	<tipc-discussion@...ts.sourceforge.net>, <kbuild-all@...org>
Subject: Re: [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc_join compile
 error

On 03/12/2015 05:59 AM, David Miller wrote:
> From: Ying Xue <ying.xue@...driver.com>
> Date: Wed, 11 Mar 2015 15:51:13 +0800
> 
>> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
>> index c25a3a1..5bb8fc9 100644
>> --- a/net/tipc/Kconfig
>> +++ b/net/tipc/Kconfig
>> @@ -29,6 +29,7 @@ config TIPC_MEDIA_IB
>>  config TIPC_MEDIA_UDP
>>  	bool "IP/UDP media type support"
>>  	depends on TIPC
>> +	depends on (IPV6=y || IPV6=n)
>>  	select NET_UDP_TUNNEL
>>  	help
>>  	  Saying Y here will enable support for running TIPC over IP/UDP
> 
> This really is not what you want.
> 
> You want to enable TIPC_MEDIA_UDP if IPV6 is "compatible" with TIPC,
> what you're using here is a sledgehammer.
> 
> I would really suggest breaking this facility out into it's own
> module, then you can mark it tristate and do this correctly.
> 
> 

Thank you for the review. OK, I will change the code again following your
suggestions.

Regards,
Ying

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html