netdev - Re: [PATCH net] xps: must clear sender

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150311.235134.2179029122534232611.davem@davemloft.net>
Date:	Wed, 11 Mar 2015 23:51:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jw@...learfallout.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] xps: must clear sender_cpu before forwarding

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 11 Mar 2015 18:42:02 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> John reported that my previous commit added a regression
> on his router.
> 
> This is because sender_cpu & napi_id share a common location,
> so get_xps_queue() can see garbage and perform an out of bound access.
> 
> We need to make sure sender_cpu is cleared before doing the transmit,
> otherwise any NIC busy poll enabled (skb_mark_napi_id()) can trigger
> this bug.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: John <jw@...learfallout.net>
> Bisected-by: John <jw@...learfallout.net>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html