netdev - Re: [PATCH net-next 1/4] bonding: Handle notifications during work-queue processing gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF2d9jggWo8Kvr3N9EAsXsEApMn-hc3hLZ+r51bR16+7quX0Ug@mail.gmail.com>
Date:	Thu, 12 Mar 2015 18:51:18 -0700
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 1/4] bonding: Handle notifications during
 work-queue processing gracefully

On Thu, Mar 12, 2015 at 11:34 AM, Maciej Żenczykowski
<zenczykowski@...il.com> wrote:
> bond_get_notif_pending(struct bonding *bond,
>                                          bond_notif_pending_t bit)
> {
>        return !!test_bit(bit, &bond->notif_work_mask);
> }
>
> imho this should use test_and_clear_bit, and you should actually never
> use the pending_clear, only have pending_set

Yes good idea, will do that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html