netdev - Re: [PATCH net] ip6_tunnel: fix error code when tunnel exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5502F85D.9050801@6wind.com>
Date:	Fri, 13 Mar 2015 15:46:53 +0100
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	me@...rre-cheynier.net,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH net] ip6_tunnel: fix error code when tunnel exists

Le 13/03/2015 14:43, Eric Dumazet a écrit :
[snip]
> These IS_ERR_OR_NULL(t) looks like defensive/lazy programming to me.
>
> A NULL pointer should not be allowed here.
>
> If t is not valid, it should be a plain error code mapping.
>
> I wish we get rid of all IS_ERR_OR_NULL() uses in networking tree,
> instead of adding plenty of them.
Ok, I agree. It was to minimize the patch.
I will rework it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html