netdev - Re: Bug in drivers/net/ethernet/freescale/fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150313.124138.958968404157280157.davem@davemloft.net>
Date:	Fri, 13 Mar 2015 12:41:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	rockford@...dex.ru, b38611@...escale.com, netdev@...r.kernel.org
Subject: Re: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is
 broken. In 4.0.0-rc3

From: Ben Hutchings <ben@...adent.org.uk>
Date: Fri, 13 Mar 2015 13:48:47 +0000

> On Mon, 2015-03-09 at 22:50 +0300, Панов Андрей wrote:
>> Hello!
>> 
>> Commit 2b995f63987013bacde99168218f9c7b252bdcf1 in 4.0.0-rc3 introduces a nasty bug in transmit, corrupting packets.
>> 
>> To reproduce:
>> 
>> $ dd if=/dev/zero of=zeros bs=1M count=20
>> $ md5sum -b zeros
>> 8f4e33f3dc3e414ff94e5fb6905cba8c *zeros
>> 
>> This checksum is correct.
>> 
>> Copy file "zeros" to another host with NFS, and it gets corrupted, checksum is changed.
>> File should be big, small amounts of transmit isn't affected.
>> 
>> I use an i.MX6 Quad board.
>> 
>> If this commit is reverted, all works fine.
> 
> And the bug described in the commit message doesn't seem to exist in the
> previous version.  The change just doesn't make sense to me.
> 
> I seem to remember DMA debug checks sometimes causing false positives
> for network I/O, too.

I'd be happy to apply a revert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html