netdev - Re: [PATCH] vxlan: fix wrong usage of VXLAN_VID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150313.130830.1630289698034246511.davem@davemloft.net>
Date:	Fri, 13 Mar 2015 13:08:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexey.kodanev@...cle.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	vasily.isaenko@...cle.com
Subject: Re: [PATCH] vxlan: fix wrong usage of VXLAN_VID_MASK

From: Alexey Kodanev <alexey.kodanev@...cle.com>
Date: Fri, 13 Mar 2015 19:13:53 +0300

> commit dfd8645ea1bd9127 wrongly assumes that VXLAN_VDI_MASK includes
> eight lower order reserved bits of VNI field that are using for remote
> checksum offload.
> 
> Right now, when VNI number greater then 0xffff, vxlan_udp_encap_recv()
> will always return with 'bad_flag' error, reducing the usable vni range
> from 0..16777215 to 0..65535. Also, it doesn't really check whether RCO
> bits processed or not.
> 
> Fix it by adding new VNI mask which has all 32 bits of VNI field:
> 24 bits for id and 8 bits for other usage.
> 
> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>

Looks good, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html