netdev - Re: [PATCH net-next 0/7] tipc: some optimizations and impovements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550319E2.2020108@donjonn.com>
Date:	Fri, 13 Mar 2015 13:09:54 -0400
From:	Jon Maloy <maloy@...jonn.com>
To:	David Miller <davem@...emloft.net>, jon.maloy@...csson.com
CC:	netdev@...r.kernel.org, paul.gortmaker@...driver.com,
	erik.hugne@...csson.com, ying.xue@...driver.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 0/7] tipc: some optimizations and impovements


On 15-03-13 12:52 PM, David Miller wrote:
> From: Jon Maloy <jon.maloy@...csson.com>
> Date: Fri, 13 Mar 2015 10:27:33 -0400
>
>> The commits in this series contain some relatively simple changes
>> that lead to better throughput across TIPC connections. We also make
>> changes to the implementation of link transmission queueing and priority
>> handling, in order to make the code more comprehensible and maintainable.
> I think you should do the SKB linearization changes properly.
>
> Simply do pskb_may_pull() before you inspect any header, and you can
> do this everwhere, even your bundling extraction code path.
Ok, I'll try that.

>
> I also don't think you even need to clone the SKB there either.

I don't don't see how we can not. We may extract many
buffers from different positions in the data area, which will
be sent in different directions, and be freed at different
moments of time.

///jon
>
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html