netdev - Re: [PATCH v2 net] inet_diag: fix possible overflow in inet_diag_dump_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150313.155500.725084979936385610.davem@davemloft.net>
Date:	Fri, 13 Mar 2015 15:55:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] inet_diag: fix possible overflow in
 inet_diag_dump_one_icsk()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 13 Mar 2015 09:49:59 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> inet_diag_dump_one_icsk() allocates too small skb.
> 
> Add inet_sk_attr_size() helper right before inet_sk_diag_fill()
> so that it can be updated if/when new attributes are added.
> 
> iproute2/ss currently does not use this dump_one() interface,
> this might explain nobody noticed this problem yet.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> v2: added missing 'static' qualifier

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html