netdev - Re: [PATCH net-next] vxlan: Don't set s_addr in vxlan_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2015 23:24:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	simon.horman@...ronome.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: Don't set s_addr in vxlan_create_sock

From: Simon Horman <simon.horman@...ronome.com>
Date: Fri, 13 Mar 2015 11:00:58 +0900

> In the case of AF_INET s_addr was set to INADDR_ANY (0) which which both
> symmetric with the AF_INET6 case, where s_addr is not set, and unnecessary
> as udp_conf is zeroed out earlier in the same function.
> 
> I suspect this change does not have any run-time effect due to compiler
> optimisations. But it does make the code a little easier on the/my eyes.
> 
> Cc: Tom Herbert <therbert@...gle.com>
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Seems totally reasonable, applied, thanks Simon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html