netdev - Re: [PATCH v2] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1426247908.2670.6.camel@jtkirshe-mobl>
Date:	Fri, 13 Mar 2015 04:58:28 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	h-shimamoto@...jp.nec.com
Subject: Re: [PATCH v2] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from
 hw_features

On Thu, 2015-03-12 at 08:22 -0700, Alexander Duyck wrote:
> This change makes it so that the HW_VLAN_CTAG_FILTER bit is not
> falsely
> advertised as being a feature that can be toggled on ixgbe parts.  The
> driver was setting the bit in features and letting it be inherited by
> hw_features, however the driver was actually ignoring the value of the
> bit
> and just assuming it was always set.  As a result VLAN filtering was
> always
> enabled which is a requirement for SR-IOV, VMDq, DCB, FCoE, and
> possibly
> other features within the adapters.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
> 
> v2: Updated patch description replacing STAG reference with CTAG
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Alex, I have applied your updated patch to my queue.

git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)