netdev - Re: [PATCH 3/4] netfilter: Fix portid types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5502E3FD.50803@nod.at>
Date:	Fri, 13 Mar 2015 14:19:57 +0100
From:	Richard Weinberger <richard@....at>
To:	Pablo Neira Ayuso <pablo@...filter.org>
CC:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	coreteam@...filter.org, netfilter-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	aloisio.almeida@...nbossa.org, lauro.venancio@...nbossa.org,
	davem@...emloft.net, kadlec@...ckhole.kfki.hu, kaber@...sh.net
Subject: Re: [PATCH 3/4] netfilter: Fix portid types

Am 13.03.2015 um 14:01 schrieb Pablo Neira Ayuso:
> On Fri, Mar 13, 2015 at 12:31:15PM +0100, Richard Weinberger wrote:
>> The netlink portid is an unsigned integer, use this type
>> also in netfilter.
> 
> This small cleanup I can still take it but...
> 
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>>  net/netfilter/nfnetlink_log.c        | 4 ++--
>>  net/netfilter/nfnetlink_queue_core.c | 7 ++++---
>>  2 files changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
>> index 11d85b3..7f00846 100644
>> --- a/net/netfilter/nfnetlink_log.c
>> +++ b/net/netfilter/nfnetlink_log.c
>> @@ -62,7 +62,7 @@ struct nfulnl_instance {
>>  	struct timer_list timer;
>>  	struct net *net;
>>  	struct user_namespace *peer_user_ns;	/* User namespace of the peer process */
>> -	int peer_portid;			/* PORTID of the peer process */
>> +	unsigned int peer_portid;		/* PORTID of the peer process */
> 
> I think you have to use u32 for consistency. Other spots use the
> datatype for the netlink portid.
> 
> I think same thing applies to other patches.

Of course! Will re-spin with u32.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html