| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150314175532.GH14761@breakpoint.cc> Date: Sat, 14 Mar 2015 18:55:32 +0100 From: Florian Westphal <fw@...len.de> To: Christian Lamparter <chunkeey@...glemail.com> Cc: Florian Westphal <fw@...len.de>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH next] drivers: wireless: carl9170: shrink carl9170_tx_info Christian Lamparter <chunkeey@...glemail.com> wrote: > On Friday, March 13, 2015 04:37:25 PM Florian Westphal wrote: > > its embededded inside rate_driver_data of the ieee80211_tx_info struct, > > which in turn is stored in skb->cb[]. > > > > In order to shrink cb, we need to shrink ieee80211_tx_info which means > > to downsize all users first. > > > > Alternatively, one might be able to remove kref but > > its less intrusive/simpler to use u32 for timeout handling. > > > > Signed-off-by: Florian Westphal <fw@...len.de> > > --- > u32 jiffies... that's a lot of pointing (well not so much) and really > ugly casting (a lot). I guess it would be easier to just use a "per-queue" > timeout watchdog like almost everybody else. This way, the driver will > be ready for the next skb->cb shrink as well. > > carl9170_tx_ampdu_timeout can be completely removed. Maybe, but there is only so much I am willing to do with "compile tested only" patches... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists