[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1426364057.4173.115.camel@decadent.org.uk>
Date: Sat, 14 Mar 2015 20:14:17 +0000
From: Ben Hutchings <ben@...adent.org.uk>
To: shh.xie@...il.com
Cc: netdev@...r.kernel.org, davem@...emloft.net,
Shaohui Xie <Shaohui.Xie@...escale.com>
Subject: Re: [PATCH] net/fsl: remove dependency FSL_SOC from MDIO
On Tue, 2015-03-10 at 18:31 +0800, shh.xie@...il.com wrote:
> From: Shaohui Xie <Shaohui.Xie@...escale.com>
>
> FSL_PQ_MDIO and FSL_XGMAC_MDIO are not really depend on FSL_SOC, they
> can build on non-PPC platforms.
If this hardware can actually be used on other architectures, fine.
If not, the dependency should be FSL_SOC || COMPILE_TEST so that the
option is only available on other architectures when developers want to
check that these drivers build.
Ben.
> Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com>
> ---
> drivers/net/ethernet/freescale/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index ba84c4a..25e3425 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -58,14 +58,12 @@ source "drivers/net/ethernet/freescale/fs_enet/Kconfig"
>
> config FSL_PQ_MDIO
> tristate "Freescale PQ MDIO"
> - depends on FSL_SOC
> select PHYLIB
> ---help---
> This driver supports the MDIO bus used by the gianfar and UCC drivers.
>
> config FSL_XGMAC_MDIO
> tristate "Freescale XGMAC MDIO"
> - depends on FSL_SOC
> select PHYLIB
> select OF_MDIO
> ---help---
--
Ben Hutchings
Q. Which is the greater problem in the world today, ignorance or apathy?
A. I don't know and I couldn't care less.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)
Powered by blists - more mailing lists