netdev - Re: [PATCH] bridge: reset bridge mtu after deleting an interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150314.191256.1947233794659640457.davem@davemloft.net>
Date:	Sat, 14 Mar 2015 19:12:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	venkat.x.venkatsubra@...cle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: reset bridge mtu after deleting an interface

From: roopa <roopa@...ulusnetworks.com>
Date: Fri, 13 Mar 2015 19:12:52 -0700

> On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote:
>> On adding an interface br_add_if() sets the MTU to the min of
>> all the interfaces. Do the same thing on removing an interface too
>> in br_del_if.
>>
>> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
>> ---
>>   net/bridge/br_if.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
>> index b087d27..1849d96 100644
>> --- a/net/bridge/br_if.c
>> +++ b/net/bridge/br_if.c
>> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct
>> net_device *dev)
>>   	 */
>>   	del_nbp(p);
>>   +	dev_set_mtu(br->dev, br_min_mtu(br));
>> +
>>   	spin_lock_bh(&br->lock);
>>   	changed_addr = br_stp_recalculate_bridge_id(br);
>>   	spin_unlock_bh(&br->lock);
> This looks good to me.
> 
> Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html