lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Mar 2015 21:43:06 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: David Miller <davem@...emloft.net> Cc: tgraf@...g.ch, netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com> Subject: [v1 PATCH 0/14] rhashtable: Kill shift/Key netlink namespace/Merge jhash Hi Dave: This series of patches deal with some niggly bits that nevertheless need to be dealt with before we can move ahead. I was trying to squeeze bucket_table->rehash in by downsizing bucket_table->size, only to find that my spot had been taken over by bucket_table->shift. Patches 1-6 kills shift and makes me feel better :) One of the things I want to do is limit the chain length. However, certain users try to hash multiple objects with the same key. This would obviously defeat any attempt to control the maximum chain length. The only current offender using rhashtable is netlink and it really has no excuse to do this at all. Patches 7-10 resolves that problem. Finally I saw that with every new rhashtable user we gained a copy of jhash as it's an inline function so every indirect reference to it results in another copy. Patches 11-14 deal with this by making jhash (or jhash2 when applicable) the function to use when the user does not select a hash function. PS I'd love to kill the indirect call on the hash but I think you guys need something other than jhash for sockets. Presumably they are not exposed to untrusted parties. But I really wonder whether that is still the case given things like namespaces where even root may be untrusted. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists