netdev - Re: [PATCH net-next v2 0/3] switchdev: add swdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150315.215526.2145369183225043489.davem@davemloft.net>
Date:	Sun, 15 Mar 2015 21:55:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us,
	roopa@...ulusnetworks.com, simon.horman@...ronome.com
Subject: Re: [PATCH net-next v2 0/3] switchdev: add swdev ops

From: David Miller <davem@...emloft.net>
Date: Sun, 15 Mar 2015 21:51:31 -0400 (EDT)

> From: sfeldma@...il.com
> Date: Sun, 15 Mar 2015 18:45:18 -0700
> 
>> v2:
>> 
>>  - Per Simon's review, squash some of the dependent commits into one to
>>    make series git bisect safe.
>> 
>> v1:
>> 
>> Per discussions at netconf, move switchdev ndo ops to a new swdev_ops to
>> keep ndo namespace clean and maintain switchdev-related ops into one place.
>> 
>> There are no functional changes here; just shuffling ops around for better
>> organization.
> 
> This looks a lot better, series applied.

Actually, reverted.

DSA doesn't build, I think you need to add a missing include
or something.

net/dsa/slave.c:577:21: error: variable ‘dsa_slave_swdev_ops’ has initializer but incomplete type
 static const struct swdev_ops dsa_slave_swdev_ops = {
                     ^
net/dsa/slave.c:578:2: error: unknown field ‘swdev_parent_id_get’ specified in initializer
  .swdev_parent_id_get = dsa_slave_parent_id_get,
  ^