netdev - Re: [PATCH net-next] tcp_metrics: fix wrong lockdep annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426515054.11398.206.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 16 Mar 2015 07:10:54 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Andrew Vagin <avagin@...allels.com>
Cc:	David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp_metrics: fix wrong lockdep annotations

On Mon, 2015-03-16 at 06:58 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> Changes in tcp_metric hash table are protected by tcp_metrics_lock
> only, not by genl_mutex
> 
> Reported-by: Andrew Vagin <avagin@...allels.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 098a697b497e ("tcp_metrics: Use a single hash table for all network namespaces.")
> ---
>  net/ipv4/tcp_metrics.c |   12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

I'll send a v2 : We also can use deref_locked() in tcp_new() to avoid
unnecessary barrier (as they are implied in rcu_dereference())
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html