[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150316.155020.1838817631290149166.davem@davemloft.net>
Date: Mon, 16 Mar 2015 15:50:20 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: gerlitz.or@...il.com
Cc: tom@...bertland.com, ogerlitz@...lanox.com,
john.r.fastabend@...el.com, netdev@...r.kernel.org,
amirv@...lanox.com, idos@...lanox.com
Subject: Re: [PATCH net-next V2 0/3] Add max rate TXQ attribute
From: Or Gerlitz <gerlitz.or@...il.com>
Date: Sun, 15 Mar 2015 23:10:25 +0200
> On Sun, Mar 15, 2015 at 7:08 PM, Tom Herbert <tom@...bertland.com> wrote:
>> On Sun, Mar 15, 2015 at 6:03 AM, Or Gerlitz <ogerlitz@...lanox.com> wrote:
>>> Add the ability to set a max-rate limitation for TX queues.
>>> The attribute name is maxrate and the units are Mbs, to make
>>> it similar to the existing max-rate limitation knobs (ETS and
>>> SRIOV ndo calls).
>
>> Guaranteed rate is often defined in conjunction with maximum rate. It
>> might be nice to add a parameter for that to the ndo function in
>> anticipation of someone supporting that also.
>
> I see -- so do we really want both from day one...? if this is the
> case, I can add that to the ndo with the value of 0 means no limit for
> maxrate and no guarantee for minrate
We can do this later.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists