netdev - Re: [PATCH 1/2 net-next] rhashtable: Avoid calculating hash again to unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150316.162202.2166849044626317059.davem@davemloft.net>
Date:	Mon, 16 Mar 2015 16:22:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH 1/2 net-next] rhashtable: Avoid calculating hash again
 to unlock

From: Thomas Graf <tgraf@...g.ch>
Date: Mon, 16 Mar 2015 10:42:26 +0100

> Caching the lock pointer avoids having to hash on the object
> again to unlock the bucket locks.
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

I'd like to hold off on this.

My understanding is that Herbert plans to expand the table size
synchonously during insert in emergency situations, and in that regime
some of these optimization won't be valid.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html