netdev - Re: [PATCH net] bnx2x: fix encapsulation features on 57710/57711

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150316.170604.832941070614134507.davem@davemloft.net>
Date:	Mon, 16 Mar 2015 17:06:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mschmidt@...hat.com
Cc:	netdev@...r.kernel.org, Yuval.Mintz@...gic.com,
	Dmitry.Kravkov@...gic.com, Ariel.Elior@...gic.com,
	erent@...atlas.com
Subject: Re: [PATCH net] bnx2x: fix encapsulation features on 57710/57711

From: Michal Schmidt <mschmidt@...hat.com>
Date: Mon, 16 Mar 2015 16:15:59 +0100

> E1x chips (57710, 57711(E)) have no support for encapsulation
> offload. bnx2x incorrectly advertises the support as available.
> 
> Setting of those features is conditional on "!CHIP_IS_E1x(bp)", but
> the bp struct is not initialized yet at this point and consequently
> any chip passes the check.
> The check must use the "chip_is_e1x" local variable instead to work
> correctly.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Applied, thanks a lot Michal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html