netdev - Re: [PATCH net-next 2/5] switchdev: use new swdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCm5H2mozRnRWwStrnXEyZY53nmjQq3i3rh4UvRetLFdQ@mail.gmail.com>
Date:	Sun, 15 Mar 2015 17:43:13 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	Jiří Pírko <jiri@...nulli.us>,
	Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net-next 2/5] switchdev: use new swdev ops

On Sun, Mar 15, 2015 at 4:44 PM, Simon Horman
<simon.horman@...ronome.com> wrote:
> Hi Scott,
>
> On Sat, Mar 14, 2015 at 11:15:04PM -0700, sfeldma@...il.com wrote:
>> From: Scott Feldman <sfeldma@...il.com>
>>
>> Move swdev wrappers over to new swdev ops (from previous ndo ops).  No
>> functional changes to the implementation.
>>
>> Signed-off-by: Scott Feldman <sfeldma@...il.com>
>
> I am a little concerned that this patch will break rocker and dsa until
> the 3rd and 4th patches of this series are applied.

Ya, I think you're right.  I was trying to be careful to not break git
bisect, but looks like I only covered the compile case, and broke the
run-time case.  I don't see anyway around this other than squashing
the rocker/dsa patches in with this one.  I'll send v2.

>
> Also it is not entirely obvious to me why you check for !ops in
> netdev_switch_parent_id_get() and netdev_switch_port_stp_update()
> but not in netdev_switch_fib_ipv4_add() and netdev_switch_fib_ipv4_del().

In the fib cases, we find the port dev from the route nexthop dev by
checking if we had swdev_parent_id_get, so we already know ops is
valid.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html