netdev - Re: [PATCH net-next v2] Configure bridge FDB ageing time using netlink.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CtxLTzqDh98bPQBS9AGdoi_-2=jSrnSJN3CL2bHE5nVoZ-cQ@mail.gmail.com>
Date:	Mon, 16 Mar 2015 12:12:39 +0530
From:	Siva Mannem <siva.mannem.lnx@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] Configure bridge FDB ageing time using netlink.

On Mon, Mar 16, 2015 at 7:43 AM, David Miller <davem@...emloft.net> wrote:
> From: Siva Mannem <siva.mannem.lnx@...il.com>
> Date: Sat, 14 Mar 2015 07:10:29 +0530
>
>> This patch allows user to configure bridge's FDB ageing using
>> netlink(for ex, iproute2). Allowed range is 10 seconds to 1000000 seconds
>> as per ieee8021QBridgeFdbAgingTime.
>>
>> Signed-off-by: Siva Mannem <siva.mannem.lnx@...il.com>
>
> The behavior of br_changelink() leaves a lot to be desired, and this
> change is making it worse.
>
> The range of the netlink attributes, the only thing that can cause
> an error, should be validated for all attributes _first_.
>
> Because right now you can have several values change state,
> then the last one has a range error, and an error is returned
> without rolling back the state.
>
> This is terrible.
>
> When this happens the user has not reliable way to figure out
> that some of the state changes it requested happened, and
> exactly which ones those were.
>
> If an error is thrown we _MUST_ not make any state changes to
> the bridge whatsoever.

Agree. Will work on it. Can it be a follow-on patch?

-- 
Regards,
Siva Mannem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html