netdev - RE: [next-queue 4/7] ixgbe: enable relaxed ordering for SPARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB01420@AcuExch.aculab.com>
Date:	Mon, 16 Mar 2015 11:49:49 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Jeff Kirsher' <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	"kernel-team@...com" <kernel-team@...com>,
	Sowmini Varadhan <sowmini.varadhan@...cle.com>
Subject: RE: [next-queue 4/7] ixgbe: enable relaxed ordering for SPARC

From: Jeff Kirsher
> This patch makes sure that relaxed ordering is not disabled when
> on SPARC, where it helps with performance.
...
>  static s32 ixgbe_start_hw_82598(struct ixgbe_hw *hw)
>  {
> +#ifndef CONFIG_SPARC
>  	u32 regval;
>  	u32 i;
> +#endif

You'd be better off putting:

#ifndef CONFIG_SPARC
#define IXGBE_DISABLE_RELAXED_ORDERING
#endif

much higher up.

Then replacing the #ifndef CONFIG_SPARC with #ifdef IXGBE_DISABLE_RELAXED_ORDERING
in the file itself.

Not that Dave M likes #if's in the body of functions.

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html