netdev - Re: [PATCH v2 net] bnx2x: Fix statistics locking scheme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150318.151059.979411313448939306.davem@davemloft.net>
Date:	Wed, 18 Mar 2015 15:10:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org, Ariel.Elior@...gic.com
Subject: Re: [PATCH v2 net] bnx2x: Fix statistics locking scheme

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Wed, 18 Mar 2015 16:14:02 +0200

> +int bnx2x_stats_safe_exec(struct bnx2x *bp,
> +			  void (func_to_exec)(void *cookie),
> +			  void *cookie)
 ...
> +	if (bp->stats_pending) {
> +		BNX2X_ERR("Failed to wait for stats pending to clear\n");
> +		return -EBUSY;

Buggy, this returns with the stats_lock still held.

In my humble opinion, you are putting very little care and effort into
this bug fix.

Also I disagree with your timeout logic.

I suspect that the real reason these timeouts are present, is that
the locking hierarchy is uncertain.

Nothing really should create the situation those trylocks seem to
be dealing with.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html