netdev - RE: [PATCH net-next 1/3] tipc: remove redundant call to tipc_node_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A2BAEFC30C8FD34388F02C9B3121859D1C3B36E0@eusaamb103.ericsson.se>
Date:	Wed, 18 Mar 2015 15:27:22 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Erik Hugne <erik.hugne@...csson.com>,
	Richard Alpe <richard.alpe@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next 1/3] tipc: remove redundant call to
 tipc_node_remove_conn



> -----Original Message-----
> From: Erik Hugne
> Sent: March-18-15 5:18 AM
> To: Richard Alpe; Jon Maloy; ying.xue@...driver.com;
> netdev@...r.kernel.org
> Cc: tipc-discussion@...ts.sourceforge.net; Erik Hugne
> Subject: [PATCH net-next 1/3] tipc: remove redundant call to
> tipc_node_remove_conn
> 
> From: Erik Hugne <erik.hugne@...csson.com>
> 
> tipc_node_remove_conn may be called twice if shutdown() is called on a
> socket that have messages in the receive queue.
> Calling this function twice does no harm, but is unnecessary and we remove
> the redundant call.
> 
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
Acked-by: Jon Maloy <jon.maloy@...csson.com>
> ---
>  net/tipc/socket.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 813847d..b6295c0
> 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -2078,7 +2078,6 @@ restart:
>  					     TIPC_CONN_SHUTDOWN))
>  				tipc_link_xmit_skb(net, skb, dnode,
>  						   tsk->portid);
> -			tipc_node_remove_conn(net, dnode, tsk->portid);
>  		} else {
>  			dnode = tsk_peer_node(tsk);
> 
> --
> 2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html