netdev - RE: [PATCH net-next 06/10] amd-xgbe: Set DMA mask based on hardware register value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB046B5@AcuExch.aculab.com>
Date:	Thu, 19 Mar 2015 17:32:58 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Tom Lendacky' <thomas.lendacky@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>
Subject: RE: [PATCH net-next 06/10] amd-xgbe: Set DMA mask based on hardware
 register value

From: Tom Lendacky
> The hardware supplies a value that indicates the DMA range that it
> is capable of using. Use this value rather than hard-coding it in
> the driver.
...
> +	/* Translate the address width setting into actual number */
> +	switch (hw_feat->dma_width) {
> +	case 0:
> +		hw_feat->dma_width = 32;
> +		break;
> +	case 1:
> +		hw_feat->dma_width = 40;
> +		break;
> +	case 2:
> +		hw_feat->dma_width = 48;
> +		break;
> +	}
> +

I see a glaring problem should the hardware ever return 3.

	David