netdev - Re: [PATCH] tipc: fix build issue when building without IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150319.150433.850095478975909930.davem@davemloft.net>
Date:	Thu, 19 Mar 2015 15:04:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	richard.alpe@...csson.com, jon.maloy@...csson.com,
	ying.xue@...driver.com, netdev@...r.kernel.org,
	tipc-discussion@...ts.sourceforge.net, erik.hugne@...csson.com
Subject: Re: [PATCH] tipc: fix build issue when building without IPv6

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Thu, 19 Mar 2015 12:13:43 -0300

> @@ -387,6 +391,11 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
>  	tuncfg.encap_destroy = NULL;
>  	setup_udp_tunnel_sock(net, ub->ubsock, &tuncfg);
>  
> +	/* At this point, IPv6 module should have been loaded in
> +	 * udp_sock_create/sock_create_kern().
> +	 */
> +	BUG_ON(!ipv6_stub);
> +

If IPV6=n this will be NULL no matter what.

And if the module load gets an error, this will be NULL as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html