netdev - Re: [PATCH net-next] rhashtable: Warn if min_size or max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150319.152450.1573636653085091157.davem@davemloft.net>
Date:	Thu, 19 Mar 2015 15:24:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next] rhashtable: Warn if min_size or max_size are
 not a power of two

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 19 Mar 2015 17:34:39 +0100

> The current code correctly limits table size to the next power of two.
> This check is solely to catch programming errors.
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
 ...
> +		roundup_pow_of_two(params->min_size) != params->min_size);

Please use "!is_power_of_two()", thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html