netdev - Re: [PATCH net-next v2 10/10] amd-xgbe: Rework the Rx path SKB allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150319.162000.938727994480466006.davem@davemloft.net>
Date:	Thu, 19 Mar 2015 16:20:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 10/10] amd-xgbe: Rework the Rx path SKB
 allocation

From: Tom Lendacky <thomas.lendacky@....com>
Date: Thu, 19 Mar 2015 15:09:08 -0500

> When the driver creates an SKB it currently only copies the header
> buffer data (which can be just the header if split header processing
> succeeded or header plus data if split header processing did not
> succeed) into the SKB. The receive buffer data is always added as a
> frag, even if it could fit in the SKB. As part of SKB creation, inline
> the receive buffer data if it will fit in the the SKB, otherwise add it
> as a frag during SKB creation.
> 
> Also, Update the code to trigger off of the first/last descriptor
> indicators and remove the incomplete indicator.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>

I do not understand the motivation for this, could you explain?

The less copying you do the better, just having the headers in the
linear area is the most optimal situation, and have all the data
in page frag references.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html