netdev - Re: [PATCH net-next] rhashtable: Round up/down min/max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150319224149.GA12641@gondor.apana.org.au>
Date:	Fri, 20 Mar 2015 09:41:49 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rhashtable: Round up/down min/max_size to
 ensure we respect limit

On Thu, Mar 19, 2015 at 10:31:13PM +0000, Thomas Graf wrote:
> Round up min_size respectively round down max_size to the next power
> of two to make sure we always respect the limit specified by the
> user. This is required because we compare the table size against the
> limit before we expand or shrink.
> 
> Also fixes a minor bug where we modified min_size in the params
> provided instead of the copy stored in struct rhashtable.
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

> ---
> Herbert: I'm fine with either approach. I figured you expected the
> user to take care of this, hence the added warning. This is perfectly
> fine with me me as well.

Thanks for fixing this.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html