netdev - Re: [PATCH 11/13] can: at91_can: use endian agnostic IO accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 17:47:26 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	<linux-can@...r.kernel.org>
CC:	<linux-kernel@...ts.codethink.co.uk>,
	<linux-arm-kernel@...ts.infradead.org>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 11/13] can: at91_can: use endian agnostic IO accessors

Le 18/03/2015 16:53, Ben Dooks a écrit :
> Change __raw accesors to  endian agnostic versions to allow the driver
> to work properly on big endian systems.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> --
> CC: Wolfgang Grandegger <wg@...ndegger.com>
> CC: Marc Kleine-Budde <mkl@...gutronix.de>
> CC: linux-can@...r.kernel.org
> CC: netdev@...r.kernel.org
> CC: Nicolas Ferre <nicolas.ferre@...el.com>

Sure!
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks, bye.


> ---
>  drivers/net/can/at91_can.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
> index eeb4b8b..f4e40aa 100644
> --- a/drivers/net/can/at91_can.c
> +++ b/drivers/net/can/at91_can.c
> @@ -291,13 +291,13 @@ static inline unsigned int get_tx_echo_mb(const struct at91_priv *priv)
>  
>  static inline u32 at91_read(const struct at91_priv *priv, enum at91_reg reg)
>  {
> -	return __raw_readl(priv->reg_base + reg);
> +	return readl_relaxed(priv->reg_base + reg);
>  }
>  
>  static inline void at91_write(const struct at91_priv *priv, enum at91_reg reg,
>  		u32 value)
>  {
> -	__raw_writel(value, priv->reg_base + reg);
> +	writel_relaxed(value, priv->reg_base + reg);
>  }
>  
>  static inline void set_mb_mode_prio(const struct at91_priv *priv,
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html