| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150320093634.GA17344@gondor.apana.org.au> Date: Fri, 20 Mar 2015 20:36:34 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Thomas Graf <tgraf@...g.ch> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>, kaber@...sh.net Subject: Re: [v1 PATCH 7/14] netfilter: Use rhashtable_lookup instead of lookup_compare On Mon, Mar 16, 2015 at 08:14:15PM +1100, Herbert Xu wrote: > On Mon, Mar 16, 2015 at 08:28:42AM +0000, Thomas Graf wrote: > > > The reason for the indirection was to not bypass the abstraction > > nft_data_cmp() provides. > > > > No objection to the change but maybe leave a comment in > > nft_data_cmp() that if one changes nft_data_cmp() one needs to > > look at nft_hash and see if the direct use of rhashtable_lookup() > > is still valid. > > Well we could preserve nft_data_cmp if necessary. It'll just > mean an extra indirect call to do the compare when needed. FWIW I've decided to ditch nft_data_cmp unless someone can show me that it's really necessary. The reason is that nft_hash_lookup already uses memcmp instead of nft_data_cmp. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists