netdev - Re: [PATCH net-next v2 1/3] switchdev: add swdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1426896253.32382.32.camel@decadent.org.uk>
Date:	Sat, 21 Mar 2015 00:04:13 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	Jiří Pírko <jiri@...nulli.us>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	"simon.horman@...ronome.com" <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next v2 1/3] switchdev: add swdev ops

On Fri, 2015-03-20 at 16:58 -0700, Scott Feldman wrote:
> On Fri, Mar 20, 2015 at 4:00 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> > On Sun, 2015-03-15 at 18:45 -0700, sfeldma@...il.com wrote:
> > [...]
> >> +/**
> >> + * struct switchdev_ops - switchdev operations
> >> + *
> >> + * int (*swdev_parent_id_get)(struct net_device *dev,
> >> + *                         struct netdev_phys_item_id *psid);
> >> + *   Called to get an ID of the switch chip this port is part of.
> >> + *   If driver implements this, it indicates that it represents a port
> >> + *   of a switch chip.
> >> + *
> >> + * int (*swdev_port_stp_update)(struct net_device *dev, u8 state);
> >> + *   Called to notify switch device port of bridge port STP
> >> + *   state change.
> >> + *
> >> + * int (*swdev_fib_ipv4_add)(struct net_device *dev, __be32 dst,
> >> + *                        int dst_len, struct fib_info *fi,
> >> + *                        u8 tos, u8 type, u32 nlflags, u32 tb_id);
> >> + *   Called to add/modify IPv4 route to switch device.
> >> + *
> >> + * int (*swdev_fib_ipv4_del)(struct net_device *dev, __be32 dst,
> >> + *                        int dst_len, struct fib_info *fi,
> >> + *                        u8 tos, u8 type, u32 tb_id);
> >> + *   Called to delete IPv4 route from switch device.
> > [...]
> >
> > This isn't correct kernel-doc syntax.
> 
> It was a cut-and-paste from netdevice.h.  Give me an example of
> correct syntax, and I'll fix these.

/**
 * struct switchdev_ops - switchdev operations
 * @swdev_parent_id_get: Called to get an ID of the switch chip this
 *	port is part of.  If driver implements this, it indicates that
 *	it represents a port of a switch chip.
 * ...
 */

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)