netdev - [PATCH] iproute2: fix broken get_prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <550DAE5A.2050303@tekcomms.com>
Date:	Sat, 21 Mar 2015 12:46:02 -0500
From:	Joe Harvell <joe.harvell@...comms.com>
To:	<netdev@...r.kernel.org>
CC:	Stephen Hemminger <shemming@...cade.com>,
	Vadim Kochan <vadim4j@...il.com>
Subject: [PATCH] iproute2: fix broken get_prefix_1

Fixes bug that causes a basic 'ip addr add' command to fail address due 
to the address prefix is incorrectly determined to be invalid.

I assume master must have some new change because this fix was needed 
for a basic 'ip addr add 10.0.3.1/24 dev dumbo label foo' command I 
pased in.  In this case, 'family' passed into get_addr_1 two lines above 
is zero, causing get_addr_1 to detect the family from the address and 
populate the result in the family field in dst.  But then instead of 
passing in the result, family (still 0) is passed in to af_bit_len. 
Without my change, the above command complains that 10.0.3.1/24 is not 
an address prefix.  With the change it works fine as expected.

The following changes since commit 4612d04d6b8f07274bd5d0688f717ccc189499ad:

   tc class: Show class names from file (2015-03-15 12:27:40 -0700)

are available in the git repository at:

   git@...hub.com:jharvell/iproute2.git fix-broken-get_prefix_1

for you to fetch changes up to 50d23ac0379cc1371f1096a4c84d8c1573c0a00a:

   Signed-off-by: Joe Harvell <joe.harvell@...comms.com> Tested-by: Joe 
Harvell <joe.harvell@...comms.com> (2015-03-21 12:35:15 -0500)

----------------------------------------------------------------
Joe Harvell (2):
       Fixing obvious error of passing in the wrong variable for the 
family parameter     of af_bit_len.
       Signed-off-by: Joe Harvell <joe.harvell@...comms.com>     
Tested-by: Joe Harvell <joe.harvell@...comms.com>

  lib/utils.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/utils.c b/lib/utils.c
index 9cda268..0d08a86 100644
--- a/lib/utils.c
+++ b/lib/utils.c
@@ -477,7 +477,7 @@ int get_prefix_1(inet_prefix *dst, char *arg, int 
family)

         err = get_addr_1(dst, arg, family);
         if (err == 0) {
-               dst->bitlen = af_bit_len(family);
+               dst->bitlen = af_bit_len(dst->family);

                 if (slash) {
                         if (get_netmask(&plen, slash+1, 0)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html