netdev - Re: [PATCH net-next V2 00/23] ptp: get ready for 2038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Mar 2015 03:43:35 +0100
From:	Arnd Bergmann <arnd@...aro.org>
To:	Richard Cochran <richardcochran@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Amir Vadai <amirv@...lanox.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Baolin Wang <baolin.wang@...aro.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Chris Metcalf <cmetcalf@...hip.com>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Luwei Zhou <b45643@...escale.com>,
	Matthew Vick <matthew.vick@...el.com>,
	Michael Chan <mchan@...adcom.com>,
	Prashant Sreedharan <prashant@...adcom.com>,
	Shradha Shah <sshah@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH net-next V2 00/23] ptp: get ready for 2038

On Saturday 21 March 2015, Richard Cochran wrote:
> This series converts the core driver methods of the PTP Hardware Clock
> (PHC) subsystem to use the 64 bit version of the timespec structure,
> making the core API ready for the year 2038.
> 
> In addition, I reviewed how each driver and device represents the time
> value at the hardware register level.  Most of the drivers are ready,
> but a few will need some work before the year 2038, as shown:
> 
>    Patch   Driver
>    ------------------------------------------------
>    12      drivers/net/ethernet/intel/igb/igb_ptp.c
>    15 ?    drivers/net/ethernet/sfc/ptp.c
>    16      drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
>    18 ?    drivers/net/ethernet/tile/tilegx.c
>    19      drivers/net/phy/dp83640.c
> 
> The commit log message documents how each driver is ready or why it is
> not ready.  For patches 15 and 18, I could not easily find out the
> hardware representation of the time value, so I would ask the
> maintainers for a review.

Very nice, thanks for joining in with the effort.

I've commented on a few smaller issues on individual patches.
Overall, I think we'd be slightly better off changing the type to
ktime_t for the interface, the main downside of that being that
we'd need to change a bit more code.

You'd still need to do the same kind of conversion, so the difference
would be very minor in the end though, so I'm fine with whichever
way you decide as the subsystem maintainer.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html