netdev - Re: [PATCH v2 0/4] rtlwifi: Use common functions for driver stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550EED87.8010008@lwfinger.net>
Date:	Sun, 22 Mar 2015 11:27:51 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Priit Laes <plaes@...es.org>, Kalle Valo <kvalo@...eaurora.org>
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 0/4] rtlwifi: Use common functions for driver stats

On 03/22/2015 08:35 AM, Priit Laes wrote:
> Hi all,
>
> This is a small fixup to unify make the drivers use common helper
> functions for driver statistics.
>
> There are no functional changes since the first posting, except dropping
> patches already applied and addressing the comments by Joe Perches.

Are there patches that are required before these work? Applying these four 
results in the following build errors:

drivers/net/wireless/rtlwifi/rtl8192de/trx.c: In function 
‘_rtl92de_query_rxphystatus’:
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:132:3: error: implicit declaration 
of function ‘rtl_query_rxpwrpercentage’ [-Werror=implicit-function-declaration]
    pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
    ^
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:192:4: error: implicit declaration 
of function ‘rtl_evm_db_to_percentage’ [-Werror=implicit-function-declaration]
     evm = rtl_evm_db_to_percentage(p_drvinfo->rxevm[i]);
     ^
drivers/net/wireless/rtlwifi/rtl8192de/trx.c:204:4: error: implicit declaration 
of function ‘rtl_signal_scale_mapping’ [-Werror=implicit-function-declaration]
     (u8)(rtl_signal_scale_mapping(pwdb_all));
     ^
cc1: some warnings being treated as errors
scripts/Makefile.build:258: recipe for target 
'drivers/net/wireless/rtlwifi/rtl8192de/trx.o' failed

I cannot find any patches that created common routines in rtlwifi.

Larry

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html