netdev - Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 14:18:39 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Andrei Maresu <andreimaresu@...il.com>
Cc:	Scott Feldman <sfeldma@...il.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

Sat, Mar 21, 2015 at 07:02:40PM CET, andreimaresu@...il.com wrote:
>Fixed a space coding style issue found by checkpatch.pl in rocker.c
>
>Signed-off-by: Andrei Maresu <andreimaresu@...il.com>
>---
> drivers/net/ethernet/rocker/rocker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>index 9fb6948..d364b12 100644
>--- a/drivers/net/ethernet/rocker/rocker.c
>+++ b/drivers/net/ethernet/rocker/rocker.c
>@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
> static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
> 				       void *ptr)
> {
>-	desc_info->desc->cookie = (uintptr_t) ptr;
>+	desc_info->desc->cookie = (uintptr_t)ptr;

Checkpatch does not mark this as an error, not even as a warning:
"CHECK: No space is necessary after a cast". I personally like the
notation with space better.


> }
> 
> static struct rocker_desc_info *
>-- 
>1.9.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html