netdev - Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit get/set time methods.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551038FB.2070200@ezchip.com>
Date:	Mon, 23 Mar 2015 12:02:03 -0400
From:	Chris Metcalf <cmetcalf@...hip.com>
To:	Richard Cochran <richardcochran@...il.com>,
	<netdev@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>,
	"Ariel Elior" <ariel.elior@...gic.com>,
	Arnd Bergmann <arnd@...aro.org>,
	Baolin Wang <baolin.wang@...aro.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	"Luwei Zhou" <b45643@...escale.com>,
	Matthew Vick <matthew.vick@...el.com>,
	"Michael Chan" <mchan@...adcom.com>,
	Prashant Sreedharan <prashant@...adcom.com>,
	Shradha Shah <sshah@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH net-next V2 19/23] ptp: tilegx: convert to the 64 bit
 get/set time methods.

On 03/21/2015 05:39 PM, Richard Cochran wrote:
> This driver calls code (via gxio_mpipe_get/set_timestamp) that makes
> the assumption that the tv_sec field is 64 bits wide.  So apparently
> this driver is 64 bit only.  So maybe this driver and device are ready
> for 2038, but maybe not.
>
> Not even compile tested.
>
> Signed-off-by: Richard Cochran<richardcochran@...il.com>

This driver is 64-bit only.  Would it make more sense to just change
the accessors from gettime/settime to gettime/settime64 and nothing
else, i.e. rely on the current behavior that timespec and timespec64
are the same type, and trust the compiler to fail it if somehow someone
tried to build this driver into a 32-bit kernel?

In any case, if you think it's better as-is, you can certainly have my

Acked-by: Chris Metcalf <cmetcalf@...hip.com>

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html