netdev - RE: Bug in drivers/net/ethernet/freescale/fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR03MB373FC71B9A8559E51084C26F50D0@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Mon, 23 Mar 2015 02:42:52 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	Fabio Estevam <festevam@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Панов Андрей <rockford@...dex.ru>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is broken.
 In 4.0.0-rc3

From: Fabio Estevam <festevam@...il.com> Sent: Sunday, March 22, 2015 6:36 AM
> To: Russell King - ARM Linux
> Cc: Панов Андрей; Duan Fugang-B38611; netdev@...r.kernel.org; linux-arm-
> kernel
> Subject: Re: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is
> broken. In 4.0.0-rc3
> 
> Hi Russell,
> 
> On Sat, Mar 21, 2015 at 5:53 PM, Russell King - ARM Linux
> <linux@....linux.org.uk> wrote:
> 
> > Given that this bug can seriously screw data up in undetectable ways
> > (TCP checksums don't save you, because the FEC generates them on the
> > data which it read from memory, even if it happened to read the data
> > from the SoC's boot ROM) we do need to get this fixed ASAP.
> 
> Current mainline has 2b995f63987013 reverted, so 4.0-rc5 will not have
> this corruption problem.
> 
> Regards,
> 
> Fabio Estevam

We cannot revert the commit 2b995f63987013, otherwise there introduce other issue. The correct fix method is Russell King's fix in the previous mail.
It is strange thing that I cannot reproduce the issue on i.MX6q sabresd board. Anyway, we must consider TSO case that it's not a fragmented skb.

Regards,
Andy