netdev - Re: [PATCH net-next v6] switchdev: fix stp update API to work with layered netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150323.164525.1089841738578904403.davem@davemloft.net>
Date:	Mon, 23 Mar 2015 16:45:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	sfeldma@...il.com, jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6] switchdev: fix stp update API to work with
 layered netdevices

From: roopa@...ulusnetworks.com
Date: Sat, 21 Mar 2015 10:27:28 -0700

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> make it same as the netdev_switch_port_bridge_setlink/dellink
> api (ie traverse lowerdevs to get to the switch port).
> 
> removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because
> direct bridge ports can be stacked netdevices (like bonds
> and team of switch ports) which may not implement this ndo.
> 
> v2 to v3:
> 	- remove changes to bond and team. Bring back the
> 	transparently following lowerdevs like i initially
> 	had for setlink/getlink
> 	(http://www.spinics.net/lists/netdev/msg313436.html)
> 	dave and scott feldman also seem to prefer it be that
> 	way and move to non-transparent way of doing things
> 	if we see a problem down the lane.
> 
> v3 to v4:
> 	- fix ret initialization
> 
> v4 to v5:
> 	- return err on first failure (scott feldman)
> 
> v5 to v6:
> 	- change variable name (err) and initialize to
> 	-EOPNOTSUPP (scott feldman).
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html